[SR-1047] Run xctest_checker tests in tests#203
Merged
Conversation
swift-corelibs-xctest uses a Python program called xctest_checker to run its functional test suite. That program itself has unit tests, written in Python. These unit tests should be run as part of the greater XCTest test suite. This is probably possible by modifying the lit.cfg in the swift-corelibs-xctest project such that it picks up on a file with a RUN: directive that triggers the Python tests. See swiftlang/swift#778 for an example. See llvm.org/docs/CommandGuide/lit.html for additional details on lit--it's the test runner for Swift, LLVM, and other projects, so it's nice to know about it.
modocache
approved these changes
Oct 6, 2017
Contributor
modocache
left a comment
modocache
left a comment
There was a problem hiding this comment.
Wow, awesome, thanks @tiagomartinho! 😍
This looks correct, but let's see what @swift-ci has to say.
Contributor
|
@swift-ci please test |
Contributor
|
Also +cc @briancroom, in case he knows anyone working on Swift CI who might not want these additional tests to be run. I don't think it'll be a problem, especially considering |
Contributor
Author
|
Thank you Brian for the detailed task description 😄 |
Contributor
|
Looks like an unrelated failure in SwiftPM, let's try again: @swift-ci please test Linux platform |
Contributor
|
Cool! This makes sense to me. I don’t know of any reason not to run these in CI. Let’s get this merged once CI goes green. Thanks @tiagomartinho! |
Contributor
Author
|
Thank you Brian! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swift-corelibs-xctest uses a Python program called xctest_checker to run its functional test suite. That program itself has unit tests, written in Python.
These unit tests should be run as part of the greater XCTest test suite. This is probably possible by modifying the lit.cfg in the swift-corelibs-xctest project such that it picks up on a file with a RUN: directive that triggers the Python tests. See swiftlang/swift#778 for an example.
See llvm.org/docs/CommandGuide/lit.html for additional details on lit--it's the test runner for Swift, LLVM, and other projects, so it's nice to know about it.